Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incident#567732673 - Add provision to set SQLServerBulkCopy options in PreparedStatement #2555

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

machavan
Copy link
Contributor

@machavan machavan commented Dec 4, 2024

Description:

Add provision to set SQLServerBulkCopyOptions in PreparedStatement via
-new connection string options
-a new method setBulkCopyOptions

Testing:

  • All tests pass
  • Added a new test BatchExecutionWithBCOptionsTest
  • TBD: Currently new tests have been added only for CheckConstraint option. Need to add tests for all the other newly addded options.

@machavan machavan changed the title Add provision to set SQLServerBulkCopy options in PreparedStatement Incident#567732673 - Add provision to set SQLServerBulkCopy options in PreparedStatement Dec 4, 2024
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 65.91928% with 76 lines in your changes missing coverage. Please review.

Project coverage is 51.18%. Comparing base (ae462f9) to head (151fcf8).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
.../microsoft/sqlserver/jdbc/SQLServerDataSource.java 0.00% 45 Missing ⚠️
...t/sqlserver/jdbc/SQLServerConnectionPoolProxy.java 3.57% 27 Missing ⚠️
...oft/sqlserver/jdbc/SQLServerPreparedStatement.java 63.63% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2555      +/-   ##
============================================
+ Coverage     50.99%   51.18%   +0.18%     
- Complexity     3911     3963      +52     
============================================
  Files           147      147              
  Lines         33456    33675     +219     
  Branches       5604     5624      +20     
============================================
+ Hits          17060    17235     +175     
- Misses        13992    14032      +40     
- Partials       2404     2408       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@machavan machavan marked this pull request as ready for review December 12, 2024 12:53
…faultsKeepIdentity and bulkCopyOptionDefaultsTableLock
@muskan124947
Copy link
Contributor

Added tests for all the options in BatchExecutionWithBCOptionsTest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Under Peer Review
Development

Successfully merging this pull request may close these issues.

2 participants