Add OCOS_ENABLE_VENDOR_IMAGE_CODECS compile definition, even if VISION is disabled #849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree company="Microsoft" |
|
/azp run "onnxruntime-extensions.CI" |
|
No pipelines are associated with this pull request. |
|
/azp run onnxruntime-extensions.CI |
|
Azure Pipelines successfully started running 1 pipeline(s). |
_DEFAULT_CODEC_ENABLE was added for these platforms which doesn't have native APIs for image codecs so that we don't need explicitly turn this flag ON or OFF for pipelines on different platforms. If this PR can resolve issue. we can merge this PR to unblock you since this flag was OFF now so it might not break any pipeline. Moreover, OCOS_ENABLE_VENDOR_IMAGE_CODECS cannot be ON by default is due to missing encoder support, with #848, we will turn on this flag. |
|
ok. so #848 will turn on OCOS_ENABLE_VENDOR_IMAGE_CODECS by default. I can wait for that PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libpngandlibjpegon Windows and Apple, ifOCOS_ENABLE_VENDOR_IMAGE_CODECSis enabledOCOS_ENABLE_VENDOR_IMAGE_CODECScompile definition whenOCOS_ENABLE_VISIONis set, assuming that decoders are not used ifVISIONis not enabled. That's not the case becauseshared\api\image_processor.ccis added forOCOS_ENABLE_C_API(CMakeLists.txt:761) andOCOS_BUILD_SHARED_LIB=OFF(CMakeLists.txt:873)In this change:
-DOCOS_ENABLE_VENDOR_IMAGE_CODECSis performed even ifVISIONis not enabled._DEFAULT_CODEC_ENABLE, andif(_DEFAULT_CODEC_ENABLE)as it is redundant given it's preceded byset(_DEFAULT_CODEC_ENABLE ON)