[DML EP] Add int16 QDQ remover #22459
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skottmckay
reviewed
Nov 4, 2024
|
|
||
| if (session_options.config_options.GetConfigOrDefault(kOrtSessionOptionsDisableDoubleQDQRemover, "0") == "0") { | ||
| // DML doesn't support int16 QDQ, so we remove all pairs that cancel eachother to avoid falling back to the CPU | ||
| transformers.emplace_back(std::make_unique<Int16QDQPairsRemover>(dml_ep)); |
There was a problem hiding this comment.
I think L1 optimizations should be EP agnostic given partitioning hasn't occurred yet so we don't know which EP will be assigned the nodes.
Instead of using an L1 optimizer, can the DML EP create a ComputeCapability for a fused node that drops the DQ/Q? Should be relatively simple to do that.
fdwr
reviewed
Nov 13, 2024
| @@ -317,6 +318,12 @@ InlinedVector<std::unique_ptr<GraphTransformer>> GenerateTransformers( | |||
| #else | |||
| const bool avx2_precision_mode = false; | |||
| #endif | |||
|
|
|||
| if (session_options.config_options.GetConfigOrDefault(kOrtSessionOptionsDisableDoubleQDQRemover, "0") == "0") { | |||
| // DML doesn't support int16 QDQ, so we remove all pairs that cancel eachother to avoid falling back to the CPU | |||
There was a problem hiding this comment.
Suggested change
| // DML doesn't support int16 QDQ, so we remove all pairs that cancel eachother to avoid falling back to the CPU | |
| // DML doesn't support int16 QDQ, so we remove all pairs that cancel each other to avoid falling back to the CPU. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context