Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert prompty based evaluators to async based implementation #3557

Merged
merged 3 commits into from
Jul 18, 2024

Conversation

ninghu
Copy link
Member

@ninghu ninghu commented Jul 17, 2024

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • I confirm that all new dependencies are compatible with the MIT license.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Copy link

github-actions bot commented Jul 17, 2024

promptflow-evals test result

 12 files   12 suites   1h 9m 36s ⏱️
 39 tests  38 ✅  1 💤 0 ❌
468 runs  456 ✅ 12 💤 0 ❌

Results for commit 6a40b26.

♻️ This comment has been updated with latest results.

@ninghu ninghu marked this pull request as ready for review July 17, 2024 19:08
@ninghu ninghu requested a review from a team as a code owner July 17, 2024 19:08
luigiw
luigiw previously approved these changes Jul 17, 2024
nagkumar91
nagkumar91 previously approved these changes Jul 18, 2024
@ninghu ninghu dismissed stale reviews from nagkumar91 and luigiw via b0d6159 July 18, 2024 16:06
@ninghu ninghu merged commit de5aa0f into main Jul 18, 2024
75 of 76 checks passed
@ninghu ninghu deleted the users/ninhu/prompty_evaluators_to_async branch July 18, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants