Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend single-step evaluation with stereo-agnostic results #102

Merged
merged 5 commits into from
Sep 13, 2024

Conversation

kmaziarz
Copy link
Contributor

@kmaziarz kmaziarz commented Sep 11, 2024

This PR adds an include_results_modulo_stereo flag to the single-step evaluation script to additionally compute metrics (top-k accuracy, MRR) under a relaxed notion of success which ignores stereochemistry information. This can be useful to assess what fraction of errors made by the model are due to a mismatch in chirality. Additionally, this PR also slightly tidies up the printing of eval results.

Copy link
Collaborator

@AustinT AustinT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (apart from a small concern about type conversion).

syntheseus/cli/eval_single_step.py Show resolved Hide resolved
syntheseus/reaction_prediction/chem/utils.py Outdated Show resolved Hide resolved
@kmaziarz kmaziarz force-pushed the kmaziarz/results-modulo-stereo branch from 0bf0c86 to d2fa118 Compare September 12, 2024 14:10
@kmaziarz kmaziarz merged commit 7efadd2 into main Sep 13, 2024
5 checks passed
@kmaziarz kmaziarz deleted the kmaziarz/results-modulo-stereo branch September 13, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants