Update GLN environment to Python 3.9 #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AustinT
approved these changes
Oct 10, 2024
kmaziarz
added a commit
that referenced
this pull request
Nov 29, 2024
Python 3.7 is well past its end-of-life; we mostly maintained support for it due to it being required to run GLN, which since #103 is no longer the case. This PR raises the minimum Python requirement to 3.8 and removes compatibility hacks that are not needed anymore. The recently released `v0.5.0` will thus be the last version to support Python 3.7, which users can fall back to if they really need to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike all other supported single-step models, GLN uses a separate environment defined with
docker, as it depends on buildingrdkitfrom source. GLN is also the only model using Python 3.7 - a version which reached its end-of-life last year. This PR keeps thedocker-based setup, but updates the GLN code and environment to Python 3.9, so that in a future version ofsyntheseuswe can raise the required Python version to 3.9 and get rid of backward compatibility hacks.