-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes java.getPackageData for modules with long name #791
Conversation
Fixes microsoft#788 Signed-off-by: Frederik Claus <f.v.claus@googlemail.com>
@microsoft-github-policy-service agree |
Thank you @fvclaus for the contribution. It's the National Holiday in China, please expect delay response. I'll make sure it's reviewed ASAP when I have time. |
@jdneo , thanks for the info. Don't worry about it. Most other projects that I have created MRs for have taken much longer to get back to me. Happy holiday. |
jdtls.ext/com.microsoft.jdtls.ext.core/src/com/microsoft/jdtls/ext/core/PackageCommand.java
Show resolved
Hide resolved
jdtls.ext/com.microsoft.jdtls.ext.core/src/com/microsoft/jdtls/ext/core/PackageCommand.java
Outdated
Show resolved
Hide resolved
jdtls.ext/com.microsoft.jdtls.ext.core/src/com/microsoft/jdtls/ext/core/PackageCommand.java
Outdated
Show resolved
Hide resolved
jdtls.ext/com.microsoft.jdtls.ext.core/src/com/microsoft/jdtls/ext/core/PackageCommand.java
Outdated
Show resolved
Hide resolved
jdtls.ext/com.microsoft.jdtls.ext.core/src/com/microsoft/jdtls/ext/core/PackageCommand.java
Show resolved
Hide resolved
Overall looks good to me! Just one more small piece :) |
Signed-off-by: Sheng Chen <sheche@microsoft.com>
@fvclaus BTW, could you re-reply the Contribution License Agreement without the quotation? Looks like the license check has some issue. Thanks! |
@microsoft-github-policy-service agree |
Thank you @fvclaus for your contribution! |
Fixes #788
Fixes #766
@jdneo, there is actually a scenario in which there is no project in
containers
. When the project does not have an pom.xml or build.gradle, then the JDT create an invisible project. That's why the tests were failing yesterday. In that case,containers
contains only one folder (the root folder, invisible projects are always created at the root folder) and I could have taken it from there, but I wanted to be more explicit in code. If you don't like it, then feel free to change it again.I also tinkered more with the Selenium tests. They will no check the build status of the language server, instead of having random sleeps scattered around the code.