Handle when onDidEndTerminalShellExecution never fires #24123
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #24078
We should rather have exitCode as a promise instead of the entire object as a promise for case:
python
command never finishes.@ The case of where shell integration is enabled in zsh/pwsh in Windows but not inside Python REPL so python command won't finish until user exit()
Cases we need to handle:
@ Shell integration in zsh/pwsh works, but not python for windows
python
command never finishespython
command never finishesThis PR takes care of the second case scenario.