Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #307: filter out saved values from the allowed values list #315

Conversation

programaka
Copy link

@programaka programaka commented Oct 1, 2024

This PR fixes #307, where the multivalue control was showing selected values (separated by a ';') as a new dropdown item. This was due to a change in the getAllowedFieldValues API, which now returns both predefined and user-saved values.

The fix filters out user-saved values from the allowed values list to prevent them from showing up as separate options.

Testing:

  • Verified that the dropdown no longer shows duplicate values.
  • Confirmed that predefined values without semicolons are still correctly displayed.
  • Tested with both 'Allow users to enter custom values' selected and unselected.

@AminTi

@programaka
Copy link
Author

I am going to close this one and create a new one from a clean state.

@programaka programaka closed this Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Control adds selected values as a new list item
1 participant