Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basics/fix errors #49

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Basics/fix errors #49

wants to merge 2 commits into from

Conversation

byronz
Copy link

@byronz byronz commented Dec 21, 2017

  1. fix some errors in slice example
  2. fix typos

@@ -625,7 +625,7 @@ With `a[:]` <4> we create a slice with all the elements in the array. This is a
And with `a[:4]` <5> we create a slice with the elements from index
0 to 3, this is short for: `a[0:4]`, and gives us a slices that contains: `1, 2, 3, 4`.
With `s2[:]` we create a slice from the slice `s2` <6>, note that `s5` still refers to the array `a`.
Finally, we create a slice with the elements from index 3 to 3 *and* also set the cap to 4 <7>.
Finally, we create a slice with the elements from index 2 to 3 *and* also set the cap to 3 instead of 5<7>.
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's about the explanation of s6 := a[2:4:5]

@@ -635,7 +635,7 @@ When working with slices you can overrun the bounds, consider this code.
At <1> we create an array with a 100 elements, indexed from 0 to 99. Then at <2>
we create a slice that has index 0 to 98. We assign 1 to the 99th element <3> of
the slice. This works as expected. But at <4> we dare to do the impossible, and
and try to allocate something beyond the length of the slice and we are greeted
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed the redundant and

@@ -16,7 +16,7 @@ World" in Go.
{callout="//"}
<{{src/basics/helloworld.go}}

Lets look at the program line by line. This first line is just required <1>. All
Let's look at the program line by line. This first line is just required <1>. All
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assuming here we mean Let us, not lets as third-person singular

@@ -4,7 +4,7 @@
1. Solve this problem, called the Fizz-Buzz [@fizzbuzz_cite] problem:

Write a program that prints the numbers from 1 to 100. But for multiples
of three print, "Fizz" instead of the number, and for multiples of
of three, print "Fizz" instead of the number, and for multiples of
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leaving the comma after the print is confusing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant