-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add developer name to appdata file #2166
Conversation
not sure if this should be set to the value I just set it to, but it seems plausible enough
WalkthroughThe changes introduced in this pull request involve the addition of a Changes
Possibly related PRs
Recent review detailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Additional comments not posted (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Similarly to #2152, this is a simple metadata update to help make the linter in the flatpak repo happy (see: flathub/no.mifi.losslesscut#66 for info)
wasnt exactly sure what to set the id to so i just used no.mifi
Developer name is a required item apparently: https://docs.flathub.org/docs/for-app-authors/metainfo-guidelines/#developer-name
also it seems like
*.appdata.xml
is no longer the current recommended filename for metadata: https://docs.flathub.org/docs/for-app-authors/metainfo-guidelines/#path-and-filename (but that's another issue for another time)Summary by CodeRabbit