Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update svg requirement from 0.10.0 to 0.13.0 #78

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 12, 2022

Updates the requirements on svg to permit the latest version.

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Updates the requirements on [svg](https://github.com/bodoni/svg) to permit the latest version.
- [Release notes](https://github.com/bodoni/svg/releases)
- [Commits](https://github.com/bodoni/svg/commits)

---
updated-dependencies:
- dependency-name: svg
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Dec 12, 2022
@codecov
Copy link

codecov bot commented Dec 12, 2022

Codecov Report

Merging #78 (23d2fba) into master (621251a) will decrease coverage by 10.77%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master      #78       +/-   ##
===========================================
- Coverage   61.82%   51.04%   -10.78%     
===========================================
  Files          13       12        -1     
  Lines        1404     1097      -307     
===========================================
- Hits          868      560      -308     
- Misses        536      537        +1     
Impacted Files Coverage Δ
src/utils.rs 77.41% <0.00%> (-11.30%) ⬇️
src/repr/histogram.rs 48.21% <0.00%> (-10.36%) ⬇️
src/axis.rs 88.75% <0.00%> (-6.23%) ⬇️
src/style.rs 69.81% <0.00%> (-2.77%) ⬇️
src/text_render.rs 94.33% <0.00%> (-2.10%) ⬇️
src/svg_render.rs 25.39% <0.00%> (-1.80%) ⬇️
tests/test_no_data.rs

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@xxhZs
Copy link

xxhZs commented Jul 22, 2024

When will the merger take place?

@fuyufjh
Copy link

fuyufjh commented Jul 23, 2024

@Cameo007 Hi, can you please help to merge this PR? Encountered this warning every time of building 🥲

warning: the following packages contain code that will be rejected by a future version of Rust: svg v0.7.2

@Cameo007
Copy link

@Cameo007 Hi, can you please help to merge this PR? Encountered this warning every time of building 🥲

warning: the following packages contain code that will be rejected by a future version of Rust: svg v0.7.2

I can't because I have no rights in this repo. I also encountered this warning.

@reavessm
Copy link

reavessm commented Dec 4, 2024

If anybody is still facing this issue, I've forked this repo and bumped the versions (and got them to compile). I can't guarantee I'll maintain this forever but it will at least get you building.

In your Cargo.toml

# plotlib = { version = ">=0.5.1", optional = true } # Needs to upgrade SVG
plotlib = { git = "https://gitlab.com/reavessm/plotlib_rs", version = ">=0.5.1", optional = true }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants