Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simple text vector search IMDB no-schema Milvus Client #1172

Merged
merged 5 commits into from
Oct 23, 2023

Conversation

christy
Copy link
Collaborator

@christy christy commented Oct 23, 2023

  • A reference to a related issue in your repository.

    Each PR is related to an issue, and you need to list that issue.

  • A description of the changes proposed in the pull request.

    This notebook adds a simple text semantic vector search example using IMDB data and no-schema Milvus Client.

    • Utility functions for splitting and search in imdb_utilities.py
    • Add an example .env file; users will need to replace values with their own tokens.
    • Add explanation AUTOINDEX is the default construction + search index; but show how to override.
    • Display question + answers together.
  • Add delight to the experience when all tasks are complete 🎉

Signed-off-by: Christy Bergman <christybergman@Christys-MacBook-Pro.local>
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: christy

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Christy Bergman added 4 commits October 23, 2023 10:56
Signed-off-by: Christy Bergman <christybergman@Christys-MacBook-Pro.local>
Signed-off-by: Christy Bergman <christybergman@Christys-MacBook-Pro.local>
Signed-off-by: Christy Bergman <christybergman@Christys-MacBook-Pro.local>
Signed-off-by: Christy Bergman <christybergman@Christys-MacBook-Pro.local>
Copy link
Collaborator Author

@christy christy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Add a .env example.
  • AUTOINDEX is the default and it is compatible with both milvus and zilliz.
  • Have the question and answers displayed together.

@christy christy merged commit 079bea9 into master Oct 23, 2023
@christy christy deleted the christy-demo branch October 23, 2023 20:28
@christy christy restored the christy-demo branch October 26, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants