Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [2.5] add recalls response for restful api #39409

Open
wants to merge 1 commit into
base: 2.5
Choose a base branch
from

Conversation

chasingegg
Copy link
Contributor

issue: #37899
pr: #39408

Signed-off-by: chasingegg <chao.gao@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Jan 17, 2025
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chasingegg
To complete the pull request process, please assign congqixia after the PR has been reviewed.
You can assign the PR to them by writing /assign @congqixia in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jan 17, 2025
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 81.03%. Comparing base (f704e3e) to head (eb8824d).

Files with missing lines Patch % Lines
...nternal/distributed/proxy/httpserver/handler_v2.go 40.00% 1 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##              2.5   #39409       +/-   ##
===========================================
+ Coverage   69.49%   81.03%   +11.54%     
===========================================
  Files         300     1404     +1104     
  Lines       26767   197575   +170808     
===========================================
+ Hits        18601   160106   +141505     
- Misses       8166    31857    +23691     
- Partials        0     5612     +5612     
Components Coverage Δ
Client 78.26% <ø> (∅)
Core 69.49% <ø> (ø)
Go 83.01% <40.00%> (∅)
Files with missing lines Coverage Δ
...nternal/distributed/proxy/httpserver/handler_v2.go 92.84% <40.00%> (ø)

... and 1103 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants