-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quilt Support #1984
base: dev
Are you sure you want to change the base?
Quilt Support #1984
Conversation
…g at the same time, resulting in one of them failing sometimes
Hi, are you in the mcdev discord? |
Yes, I'm anonym123 |
This reverts commit bf81f89.
# Conflicts: # src/main/kotlin/util/MinecraftTemplates.kt
uses a segmented button, allows for QSL selection, but warns that it isnt supported and disables version selection
This PR is now at a state where I finished the stuff I'm able to do on my own, and it has the important features fabric has. I updated the description accordingly. |
Why won't this get merged already! This is literally 1984 (this is a joke) |
Heya, can I have a status update on this |
Any news on this? |
I will defer this to @Earthcomputer - when he has the time and is able to review, it'll happen. Please be patient, this project has a very small team and none of us have an abundance of time. |
Is this already in some alpha version? Because the pull request isn't closed yet. |
LGPL 100% allows for you to compile their fork and run it for yourself. |
Since I don't have the energy to keep this updated and it doesn't seem like it'll get merged anytime soon I'm closing this for the time being. I can update it if y'all plan on merging it, feel free to message me then. In the meantime I don't recommend anyone to use my fork, as it is severly outdated by now and some issues have been fixed for fabric that might affect quilt too. |
We will keep this PR up to date once we plan on merging it, which is when Quilt pushes a full release. |
Is there a reason to wait for a full Quilt release? Quilt's overarching system is fairly stable, so I don't think there will be any big changes to it which would cause breaks with MCDev. |
Would kind of like to easily setup my development environment? |
Quilt is in a fairly stable state so there is really little reason to wait for it to leave Beta. |
This is a initial implementation of Quilt support. I implemented it by copying most of fabric's file and searching for usages. This means that there is a lot of duplicated code.
The template closely follows the official template mod, and use a
libs.versions.toml
as a version catalog.The authors field may contain a comma separated list of colon-separated key-value pairs and can be optionally wrapped in braces, spaces around these characters are trimmed:
Me: Owner, asdf: Lead Dev
While there is still a lot of stuff left to do, the rough edges seem to be done now and I figured I'd put this out here
Stuff still left to investigate:
Decisions I made I'm unsure about:
quilt.mod.json
, but Quilt has a schema. However I expect that one to be added to the schema store, so it hopefully won't be required anywaysKnown issues that I consider out of scope for this PR
Fixes #1827