feat: add v4 branch protections #128
Conversation
taharah
force-pushed
the
branch-protections
branch
from
1c19047
to
4a001f6
Compare
|
This appears to need a rebase. |
|
@taharah do you have time to get this ready for review? This would be helpful for my team. If now I’m happy to take it over. |
|
Also - optional attrs came out of preview so that part can be removed! (Min tf version will need to be bumped up) |
I'll get this updated tonight for TF 1.3+. On another note, should this continue to maintain backwards compatibility for v3 protections, or would a breaking change with the appropriate version bump be acceptable? |
Signed-off-by: Trevor Wood <Trevor.G.Wood@gmail.com>
taharah
force-pushed
the
branch-protections
branch
from
4d74080
to
d17416d
Compare
Signed-off-by: Trevor Wood <Trevor.G.Wood@gmail.com>
|
I am not a maintainer of this repo, though I'm happy to give it a second set of eyes. |
|
I'm not a maintainer either. Only a happy user, and hopefully also able to help to get this into the main branch. |
|
hey guys, sorry for the delay! We'll review this shortly and come back to you! |
Signed-off-by: Trevor Wood <Trevor.G.Wood@gmail.com>
|
@mariux or @soerenmartius would it be possible to get a review please? |
|
sorry for the delay... we added the provided feature but in a slightly different way to support computed values in some scenarios also restoring terraform 1.0 compatibility. We just released the new version. Thanks again for providing the feature. |
Adds v4 branch protections as a separate resource. If v4 branch protections are set, then it will disable the v3 branch protection resource to prevent any conflicts.
Resolves #124
Signed-off-by: Trevor Wood Trevor.G.Wood@gmail.com