Fix issues from Sonar

mingyaulee · Sep 16, 2022 · fff66ed · fff66ed
1 parent 5fa6505
commit fff66ed
Show file tree

Hide file tree

Showing 6 changed files with 13 additions and 13 deletions.
diff --git a/src/JsBind.Net/content/dist/JsBindNet.js b/src/JsBind.Net/content/dist/JsBindNet.js
@@ -623,7 +623,7 @@
      * @param {any} key
      * @param {any} value
      */
-    revive(key, value) {
+    revive(_key, value) {
       if (IsDelegateReference(value)) {
         return DelegateReferenceHandler.getOrCreateDelegateProxy(value).proxyFunction;
       }
@@ -667,7 +667,7 @@
      * @param {any} key
      * @param {any} value
      */
-    revive(key, value) {
+    revive(_key, value) {
       if (IsObjectBindingConfiguration(value)) {
         if (value.id) {
           this.foundObject(value);
@@ -734,7 +734,7 @@
      * @param {any} key
      * @param {any} value
      */
-    revive(key, value) {
+    revive(_key, value) {
       if (IsObjectReference(value)) {
         return JsObjectHandler.getObjectFromAccessPath(value.accessPath);
       }
@@ -972,4 +972,4 @@
 
   globalThis.JsBindNet = new JsBindNet();
 
-}());
+})();
diff --git a/src/JsBind.Net/content/src/Modules/Guid.js b/src/JsBind.Net/content/src/Modules/Guid.js
@@ -8,8 +8,8 @@
       return globalThis.crypto.randomUUID();
     }
 
-    return ([1e7] + -1e3 + -4e3 + -8e3 + -1e11).replace(/[018]/g, c =>
-      (c ^ globalThis.crypto.getRandomValues(new Uint8Array(1))[0] & 15 >> c / 4).toString(16)
+    return (1e7.toString() + -1e3 + -4e3 + -8e3 + -1e11).replace(/[018]/g, c =>
+      (parseInt(c) ^ globalThis.crypto.getRandomValues(new Uint8Array(1))[0] & 15 >> parseInt(c) / 4).toString(16)
     );
   }
 }

diff --git a/src/JsBind.Net/content/src/Modules/JsonRevivers/DelegateReferenceReviver.js b/src/JsBind.Net/content/src/Modules/JsonRevivers/DelegateReferenceReviver.js
@@ -4,10 +4,10 @@ import { IsDelegateReference } from "../References/DelegateReference.js";
 class DelegateReferenceReviverClass {
   /**
    * Converts a DelegateReference JSON object to a proxy function.
-   * @param {any} key
+   * @param {any} _key
    * @param {any} value
    */
-  revive(key, value) {
+  revive(_key, value) {
     if (IsDelegateReference(value)) {
       return DelegateReferenceHandler.getOrCreateDelegateProxy(value).proxyFunction;
     }

diff --git a/src/JsBind.Net/content/src/Modules/JsonRevivers/ObjectBindingConfigurationReviver.js b/src/JsBind.Net/content/src/Modules/JsonRevivers/ObjectBindingConfigurationReviver.js
@@ -19,10 +19,10 @@ class ObjectBindingConfigurationReviverClass {
 
   /**
    * Revives reference binding configuration.
-   * @param {any} key
+   * @param {any} _key
    * @param {any} value
    */
-  revive(key, value) {
+  revive(_key, value) {
     if (IsObjectBindingConfiguration(value)) {
       if (value.id) {
         this.foundObject(value);

diff --git a/src/JsBind.Net/content/src/Modules/JsonRevivers/ObjectReferenceReviver.js b/src/JsBind.Net/content/src/Modules/JsonRevivers/ObjectReferenceReviver.js
@@ -4,10 +4,10 @@ import { IsObjectReference } from "../References/ObjectReference.js";
 class ObjectReferenceReviverClass {
   /**
    * Converts an ObjectReference JSON object to an object.
-   * @param {any} key
+   * @param {any} _key
    * @param {any} value
    */
-  revive(key, value) {
+  revive(_key, value) {
     if (IsObjectReference(value)) {
       return JsObjectHandler.getObjectFromAccessPath(value.accessPath);
     }

diff --git a/test/JsBind.Net.TestsRunner/Runner.cs b/test/JsBind.Net.TestsRunner/Runner.cs
@@ -19,7 +19,7 @@ public class Runner
         public async Task RunTests()
         {
             var currentDirectory = Directory.GetCurrentDirectory();
-            var solutionDirectory = currentDirectory.Substring(0, currentDirectory.IndexOf("\\test"));
+            var solutionDirectory = currentDirectory[..currentDirectory.IndexOf("\\test")];
             var driverPath = "C:\\SeleniumWebDrivers\\ChromeDriver";
             var resultsPath = $"{solutionDirectory}\\test\\TestResults";
 #if DEBUG