Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support replication of deleted ILM expiry rules #1893

Closed
wants to merge 3 commits into from

Conversation

shtripat
Copy link
Contributor

No description provided.

@shtripat shtripat requested a review from poornas October 23, 2023 11:06
@shtripat shtripat force-pushed the remove-bucket-lifecycle branch from 74a6845 to 0508720 Compare October 24, 2023 08:13
@zveinn zveinn self-requested a review October 27, 2023 08:58
api-bucket-lifecycle.go Outdated Show resolved Hide resolved
api-bucket-lifecycle.go Outdated Show resolved Hide resolved
api-bucket-lifecycle.go Outdated Show resolved Hide resolved
@zveinn zveinn self-requested a review October 27, 2023 17:05
Signed-off-by: Shubhendu Ram Tripathi <shubhendu@minio.io>
Signed-off-by: Shubhendu Ram Tripathi <shubhendu@minio.io>
@shtripat shtripat force-pushed the remove-bucket-lifecycle branch from 0508720 to 6fbe029 Compare October 30, 2023 08:54
pkg/lifecycle/lifecycle.go Outdated Show resolved Hide resolved
Signed-off-by: Shubhendu Ram Tripathi <shubhendu@minio.io>
@harshavardhana
Copy link
Member

So what does this ExpiryRuleRemoved do ? is this to indicate that this ILM expiration must be replicated? what is it about?

@shtripat
Copy link
Contributor Author

So what does this ExpiryRuleRemoved do ? is this to indicate that this ILM expiration must be replicated? what is it about?

Yes, this would be used for replication of ILM expiry rules removal to other sites. In this case when we remove the rules, we set current time at expiryUpdatedAt and using that this removal is replicated to other sites as other sites would have older/no value of expiryUpdatedAt

@harshavardhana
Copy link
Member

Yes, this would be used for replication of ILM expiry rules removal to other sites. In this case when we remove the rules, we set current time at expiryUpdatedAt and using that this removal is replicated to other sites as other sites would have older/no value of expiryUpdatedAt

So this is a ILM configuration?

@shtripat
Copy link
Contributor Author

Yes, this would be used for replication of ILM expiry rules removal to other sites. In this case when we remove the rules, we set current time at expiryUpdatedAt and using that this removal is replicated to other sites as other sites would have older/no value of expiryUpdatedAt

So this is a ILM configuration?

yes

@harshavardhana
Copy link
Member

So this option is like enabling ILM site replication vs not?

@shtripat
Copy link
Contributor Author

So this option is like enabling ILM site replication vs not?

Kind of. For enabling replication of ILM rule removal across sites in case of site replication enabled. If not this flag doesnt have any impact. Also this flag is not saved as part of ILM config, rather considered for setting expiryUpdatedAt field of ILM config. Because in case of ILM rules removal as well we want to update the expiryUpdatedAt field for the ILM config so that while replication of expiry rules, we know that there was a removal with latest time and other sites as well should remove the rules.

@shtripat
Copy link
Contributor Author

This PR wont be needed anymore with changes in mc as part of minio/mc@6c94adc

@zveinn zveinn closed this Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants