Add Full Object Checksum API #2026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for full object checksums as described here: https://docs.aws.amazon.com/AmazonS3/latest/userguide/checking-object-integrity.html To enable, use `ChecksumCRC64NVME`, `ChecksumFullObjectCRC32` or `ChecksumFullObjectCRC32C` as checksum type when uploading. Mint tests updated, but can be disabled with `MINT_NO_FULL_OBJECT=anything` env var. PR will fail against community MinIO without above env var.
fwessels
reviewed
Dec 3, 2024
fwessels
reviewed
Dec 3, 2024
fwessels
reviewed
Dec 3, 2024
harshavardhana
approved these changes
Dec 6, 2024
klauspost
added a commit
to klauspost/minio
that referenced
this pull request
Dec 8, 2024
Remove expected failures from minio/minio-go#2026
1 task
harshavardhana
pushed a commit
to minio/minio
that referenced
this pull request
Dec 10, 2024
Remove expected failures from minio/minio-go#2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for full object checksums as described here:
https://docs.aws.amazon.com/AmazonS3/latest/userguide/checking-object-integrity.html
To enable, use
ChecksumCRC64NVME,ChecksumFullObjectCRC32orChecksumFullObjectCRC32Cas checksum type when uploading.Mint tests updated, but can be disabled with
MINT_NO_FULL_OBJECT=anythingenv var.PR will fail against community MinIO without above env var.
Validated against AWS S3.