Rpc_genfake: introduce maxcomb to limit number of combinations #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seq.cycle is not available in ocaml 4.08 (probably other methods as well) Should these definitions be added where they are used, or should a compatibility library be used instead? |
|
We could even drop compatibility with older ocaml if you ask me |
Rpc_genfake generates lists, and then throws away all elements except first when depth limit is reached. Use Seq.t instead so we can avoid generating the data that we'd throw away. Signed-off-by: Edwin Török <edwin.torok@cloud.com>
For a struct with `n` field, each with `m` values, this might otherwise try to generate `m`^`n` values. Signed-off-by: Edwin Török <edwin.torok@cloud.com>
|
@Vincent-lau 's PR dropped compat with old OCaml versions, and the CI passes now. |
mseri
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we no longer run out of memory trying to generate tests for
Xenops_interfacewithmaxcomb:100ormaxcomb:1000.This builds on top of #176
Still TODO:
gen_nicestill dies on recursive datatypes, which prevent generating documentation in some cases, noticed by @psafont , but I'll leave that for yet another PR (it is not obvious how to limit it there, because it must return a type 'a', so likely we need to perform the 'seen' check before making the call)