Fix unmarshaling: Int32 for Rpc.t, and Base64/Datetime for JSONRPC #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Edwin Török <edwin.torok@cloud.com>
Rpc.Int32 is never created by this library, but XAPI does create it for backwards compatibility with its XMLRPC events protocol. Using either JSONRPC or XMLRPC to marshal/unmarshal works, but passing an Rpc.t directly fails. Signed-off-by: Edwin Török <edwin.torok@cloud.com>
JSONRPC marshals these as string, but then trying to unmarshal would raise an exception. We need to accept String when unmarshaling DateTime and Base64 too. Some type safety is lost, because JSON doesn't have a way to distinguish between these (XMLRPC does). Update the unit test to check that this now works. Signed-off-by: Edwin Török <edwin.torok@cloud.com>
robhoes
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of these work with XMLRPC, but unmarshaling base64 or datetime fails with jsonrpc.
Add some tests to check that all Rpc.t values can be marshaled/unmarshaled.
A more thorough QCheck based test could also be added, but that'll be done in a followup PR.
Rpc.Int32 also fails to be processed by
int32_of_rpc. This value isn't actually created anywhere in this library, but XAPI uses it for backwards compatibility reasons in its Events code (to emit an XmlRPCi4), and then adding a fastpath to the event code that passes Rpc.t internally fails because it cannot be converted back. I've got a workaround for that in XAPI, but we should also fix it here.Draft PR, because this requires some internal testing with XAPI too.