Add filter for string contains case insensitive #816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@marthacryan is attempting to deploy a commit to the trymito Team on Vercel. A member of the Team first needs to authorize it. |
naterush
suggested changes
Jul 7, 2023
| FC_STRING_CONTAINS_CASE_INSENSITIVE, | ||
| "aBc", | ||
| pd.DataFrame(data={"A": ["abcDEF", "ABCdef"]}), | ||
| ), |
There was a problem hiding this comment.
Two more tests that might be nice:
- Combining two contains case insensitive with an And
- Combinion two contains case insensitive with an Or
Just so we cover all our cases here and make sure they are working properly!
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
marthacryan
force-pushed
the
case-insensitive
branch
from
4f65dbd
to
6028475
Compare
marthacryan
force-pushed
the
case-insensitive
branch
from
eee7df0
to
98ba82f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a string filter condition for contains w/ case insensitive.
For comparison, these are the results with contains:
And these are with contains case insensitive:
