Add support for highlighting border between columns when dragging #825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
aarondr77
reviewed
Jul 12, 2023
There was a problem hiding this comment.
Nice job with the spec + implementation. This makes reordering columns a much more pleasant experience.
This is working really well when the grid has only a few columns, but when the data gets larger, it becomes a big laggy. I left a couple of refactor ideas that might be helpful, but happy to brainstorm more on this!
marthacryan
force-pushed
the
column-reorder
branch
from
ca6849b
to
309941e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the following behavior: when the user is dragging a column header across the page to reorder, the UI highlights the border between columns that it would be placed in to emphasize to the user where the column is being dropped.
Note: Deleted the
mito_frontend.*files because they're now in the gitignore.