Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Supplement tags #1381

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from
Draft

Supplement tags #1381

wants to merge 14 commits into from

Conversation

GavMason
Copy link

@GavMason GavMason commented May 8, 2023 •
edited by georgedias
Loading

In order to allow for functionality to extract and overwrite tags in HDF or Inspec Profile JSON files, supplement tags read and write commands were added.

Resolves #1293

  • Add read command functionality
  • Add write command functionality
  • Add -c flag to target specific control id's
  • Add extend command functionality

wiki information related to Supplement-HDF-files-with-additional-information

Amndeep7 and others added 7 commits May 1, 2023 14:41
@Amndeep7
first pass on supplement tags - write is just a copy, read has been e…
e69c4f9 
…dited

Signed-off-by: Amndeep Singh Mann <amann@mitre.org>
@GavMason
Added filtering on controls (-c) for Read Tags
b317727 
Signed-off-by: Gavin Mason <75515923+GavMason@users.noreply.github.com>
@Amndeep7
put filter in the correct location and added another example
99598a9 
Signed-off-by: Amndeep Singh Mann <amann@mitre.org>
@GavMason
Added tags write functionality
52d727c 
Signed-off-by: Gavin Mason <75515923+GavMason@users.noreply.github.com>
@GavMason
Updated tags write command to handle only HDF/InspecProfile inputs an…
22fbc18 
…d fixed descriptions

Signed-off-by: Gavin Mason <75515923+GavMason@users.noreply.github.com>
@GavMason
Small fix for tags write functionality for HDF type inputs
4baa6ef 
Signed-off-by: Gavin Mason <75515923+GavMason@users.noreply.github.com>
@GavMason
Added write command functionality
4eeb952 
Signed-off-by: Gavin Mason <75515923+GavMason@users.noreply.github.com>
@GavMason GavMason requested a review from Amndeep7 May 8, 2023 20:22
@GavMason GavMason added the enhancement New feature or request label May 8, 2023
@Amndeep7 Amndeep7 marked this pull request as draft May 9, 2023 16:11
Amndeep7
Amndeep7 requested changes May 9, 2023
View reviewed changes
src/commands/supplement/tags/write.ts Outdated Show resolved Hide resolved
src/commands/supplement/tags/write.ts Outdated Show resolved Hide resolved
src/commands/supplement/tags/write.ts Outdated Show resolved Hide resolved
src/commands/supplement/tags/write.ts Outdated Show resolved Hide resolved
src/commands/supplement/tags/write.ts Outdated Show resolved Hide resolved
GavMason added 3 commits May 9, 2023 15:57
@GavMason
Fixed non-type requested changes
617d459 
Signed-off-by: Gavin Mason <75515923+GavMason@users.noreply.github.com>
@GavMason
Added type fixes for requested changes
1c4029f 
Signed-off-by: Gavin Mason <75515923+GavMason@users.noreply.github.com>
@GavMason
Cleaned up code
a13185c 
Signed-off-by: Gavin Mason <75515923+GavMason@users.noreply.github.com>
@GavMason GavMason requested a review from Amndeep7 May 10, 2023 13:43
GavMason added 4 commits May 11, 2023 09:06
@GavMason
Fix flag mismatch
e015493 
Signed-off-by: Gavin Mason <75515923+GavMason@users.noreply.github.com>
@GavMason
Undo last commit
24e4a3e 
Signed-off-by: Gavin Mason <75515923+GavMason@users.noreply.github.com>
@GavMason
Added tags extend functionality
fe7155b 
Signed-off-by: Gavin Mason <75515923+GavMason@users.noreply.github.com>
@GavMason
Added dev notes/TODOs
fabaf53 
Signed-off-by: Gavin Mason <75515923+GavMason@users.noreply.github.com>
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

No Coverage information No Coverage information
26.5% 26.5% Duplication

@GavMason GavMason changed the title Supplement tags. Supplement tags May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Amndeep7 Amndeep7 Awaiting requested review from Amndeep7

Requested changes must be addressed to merge this pull request.

Assignees

@Amndeep7 Amndeep7

@GavMason GavMason

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add "saf supplement tag" command
2 participants
@GavMason @Amndeep7