CMakeLists: Add support for targeting Emscripten/WebAssembly #12918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue turned out to be the missing `clang-scan-deps` binary in the compiler invocation in `check_cxx_source_compiles`. Note for future self and anyone debugging this: build/CMakeFiles/ CMakeConfigureLog.yaml is really useful here.
Emscripten does not support -mtune=generic or -mfpmath=sse. It does support -msse2, however only if -msimd128 or -mrelaxed-simd is also set. Note that Emscripten sets `CMAKE_SYSTEM_PROCESSOR` to `x86`.
13 tasks
fwcd
commented
Mar 4, 2024
Comment on lines
+157
to
+159
| if(NOT DEFINED VCPKG_CHAINLOAD_TOOLCHAIN_FILE) | ||
| set(VCPKG_CHAINLOAD_TOOLCHAIN_FILE "$ENV{EMSDK}/upstream/emscripten/cmake/Modules/Platform/Emscripten.cmake" CACHE STRING "") | ||
| endif() |
There was a problem hiding this comment.
Might be redundant, since the vcpkg triplet (wasm32-emscripten or any of its derivatives) should already set this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds initial support for targeting Emscripten/WebAssembly. Most of the changes are relatively straightforward with just some smaller quirks to work around (e.g. the SSE flags or OpenGL).