AutoDj: Option to start the Crossfader centered so the track starts at full volume (default off). #13619
Conversation
Option to set the Crossfader to the center as AutoDj starts a crossfade so the track starts at full volume.
| // movements in this track's play position. | ||
| setCrossfader(currentCrossfader + adjustment); | ||
| if ((m_crossfaderStartCenter) && | ||
| (transitionProgress <= ((thisDeck->fadeEndPos - thisDeck->fadeBeginPos)/2))) { |
There was a problem hiding this comment.
| (transitionProgress <= ((thisDeck->fadeEndPos - thisDeck->fadeBeginPos)/2))) { | |
| transitionProgress <= std::midpoint(thisDeck->fadeBeginPos, thisDeck->fadeEndPos) { |
There was a problem hiding this comment.
If you mean to use the standard lib calls instead of the arithmetic, then sure, that makes the intent clearer. (My C++ usage has been mostly on micro-controllers where one avoids both the speed and space overhead of libraries if possible.)
| switch (m_transitionMode) { | ||
| // case TransitionMode::RadioFullIntroOutro: | ||
| case TransitionMode::FullIntroOutro: { |
There was a problem hiding this comment.
Yes. This was an artifact of an earlier experiment. I thought I had removed all of those.
|
|
||
|
|
||
| ControlProxy* m_pCOCrossfader; |
There was a problem hiding this comment.
I don't think m_pCOCrossfader has anything to do with my code, other than I used it as a template for some of my changes. I think m_pCOCrossfader refers to #13303.
|
Thank you for this PR. I wonder what exactly is your use case and if this plays nicely with all transition modes and configured intros. I can confirm that throwing a track in at full volume is a good solution when they start with vocals right away. What your use case? |
|
There are style changes in unrelated regions if the code. |
Some of those changes look liek pre-commit proposals. Do you have that installed? |
Co-authored-by: ronso0 <ronso0@mixxx.org>
Co-authored-by: ronso0 <ronso0@mixxx.org>
I did for the second attempt. I had thought that the clang-format would be tied into the VS settings, and because I hadn't run it this was the cause of the original reject. [Lots of gratuitous commentary of code formatting redacted here.] Most of this tool set (including git really) is pretty alien to me, so I am probably making quite a mess of this. However, the code changes are simple and do work across all four AutoDj options. |
|
Thanks, I'll take another look soon. FYI: resoving review conversations should be done by the reviewer. Otherwise (contributor) responses are hidden and it's tedious for the reviewer to expand and double-check previous reviews. Thanks! |
|
Can this one be closed in favour of: #13628? |
|
Yes. Change addressed in 13628(#13628). |
|
Change addressed in 13628(#13628). |
Option to set the Crossfader to the center as AutoDj starts a crossfade so the track starts at full volume.
This overcomes the issue of a track fading in, so that it loses the start, especially on cold start vocals or drum fills. This sounds much more professional, especially for community radio or internet stations.
The setting is in preferences Auto DJ under Crossfader Behaviour (noting that the hint also applies to this setting).
When set all of the AutoDj settings are affected, however, despite starting from the middle the crossfade still takes the same time.