Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(fix) Controllers: return from loadSettings() when there's no mapping file #13738

Merged
merged 1 commit into from
Oct 12, 2024
Merged

(fix) Controllers: return from loadSettings() when there's no mapping file #13738

merged 1 commit into from
Oct 12, 2024
+5 −1

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Oct 8, 2024

Fixes #13728

@ronso0 ronso0 mentioned this pull request Oct 8, 2024
Open
@JoergAtGithub
Copy link
Member

I think 2.5 is the correct target here?

@ronso0
Copy link
Member Author

ronso0 commented Oct 12, 2024

oh, thanks, I wasn't aware the settings landed in 2.5 already.

Swiftb0y
Swiftb0y approved these changes Oct 12, 2024
View reviewed changes
Copy link
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thank you.

@JoergAtGithub JoergAtGithub changed the base branch from main to 2.5 October 12, 2024 13:30
@JoergAtGithub JoergAtGithub merged commit 46ed229 into mixxxdj:2.5 Oct 12, 2024
13 checks passed
@ronso0 ronso0 deleted the mapping-file-doesnt-exist branch October 13, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acolombier acolombier acolombier approved these changes

@Swiftb0y Swiftb0y Swiftb0y approved these changes

Assignees
No one assigned
Labels
controller backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DEBUG ASSERT: "mappingFile.exists()" in LegacyControllerMapping::loadSettings()
4 participants
@ronso0 @JoergAtGithub @acolombier @Swiftb0y