support Jira GDPR changes. Fix but where job stops on error

jira.go

@@ -129,12 +129,12 @@ type UpdatedWorklogs struct {
 type Worklog struct {
 	Self   string `json:"self"`
 	Author struct {
-		Self         string `json:"self"`
-		Name         string `json:"name"`
-		Key          string `json:"key"`
-		AccountID    string `json:"accountId"`
-		EmailAddress string `json:"emailAddress"`
-		AvatarUrls   struct {
+		Self string `json:"self"`
+		//Name         string `json:"name"`
+		//Key          string `json:"key"`
+		AccountID string `json:"accountId"`
+		//EmailAddress string `json:"emailAddress"`
+		AvatarUrls struct {
 			Four8X48  string `json:"48x48"`
 			Two4X24   string `json:"24x24"`
 			One6X16   string `json:"16x16"`

job/JiraWorklogsDownloader.go

@@ -1,13 +1,14 @@
 package job
 
 import (
+	"strings"
+	"time"
+
 	"github.com/mkobaly/jiraworklog"
 	"github.com/mkobaly/jiraworklog/repository"
 	"github.com/mkobaly/jiraworklog/types"
 	"github.com/pkg/errors"
 	log "github.com/sirupsen/logrus"
-	"strings"
-	"time"
 )
 
 //JiraWorklogsDownloader is a background job that will download all worklogs from Jira
@@ -115,7 +116,7 @@ func (j *JiraWorklogsDownloader) okToProcess(w jiraworklog.Worklog, userNames []
 	}
 
 	for _, u := range userNames {
-		if strings.ToLower(w.Author.Key) == strings.ToLower(u) {
+		if strings.ToLower(w.Author.DisplayName) == strings.ToLower(u) {
 			return true
 		}
 	}

types/worklogItem.go

@@ -47,7 +47,7 @@ func ConvertToModels(w jiraworklog.Worklog, i jiraworklog.Issue, parentIssue jir
 
 	worklogResult := &WorklogItem{
 		ID:            id,
-		Author:        w.Author.Key,
+		Author:        w.Author.DisplayName,
 		Project:       strings.Split(i.Key, "-")[0],
 		IssueID:       issueID,
 		IssueKey:      i.Key,

worker.go

@@ -44,15 +44,18 @@ func (w *Worker) Start() {
 //Run will execute the given job
 func (w *Worker) Run(job Job) {
 	for {
+		hasError := false
 		started := time.Now()
 		err := job.Run()
 		if err != nil {
 			w.logger.WithError(err).WithField("job", job.GetName()).Error("job run failed")
-			return
+			hasError = true
+		}
+		if !hasError {
+			finished := time.Now()
+			duration := finished.Sub(started)
+			w.logger.WithField("duration", duration).WithField("job", job.GetName()).Info("job run complete")
 		}
-		finished := time.Now()
-		duration := finished.Sub(started)
-		w.logger.WithField("duration", duration).WithField("job", job.GetName()).Info("job run complete")
 
 		select {
 		case <-w.stopChan: