fix: hot reload didn't work property #61
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed hot reload didn't work proprety when running in macOS desktop mode
This is due to behaviour change in go_router start from 13.0, go_router
pageBuilder
no longer called after hot reload, that meanslide.widget.build(context)
will only call once on init state, and causeFlutterDeckSlideWidget.build
will not call again to reflect the change (like change the title inFlutterDeckSlide.title(title: 'xxx')
)flutter_deck/lib/src/flutter_deck_router.dart
Lines 62 to 66 in e68f538
Do fix this issue, this PR will move
slide.widget.build(context)
to a wrapper widget so it will trigger when hot reload is performedType of Change