feat: Add a builder for speakerInfo #68
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Description
Related to #62, I found another issue that
speakerInfo
can't be localized as the object is created outside ofFlutterDeckApp
, meaning outside ofMaterialApp
.I could solve the problem by wrapping
FlutterDeckApp
with anotherMaterialApp
like belowbut that seems inefficient, and the biggest problem is that changing the locale feature of the control is not applied on
FlutterDeckTitleSlide
.Here is my proposal to add a
Builder
version ofspeakerInfo
which allows users to useBuildContext
that is at least a descendant ofFlutterDeckApp
.This enables users to simply write like below.
Type of Change