Revamp MLX C API #38
Revamp MLX C API #38
Conversation
|
|
||
| .. code-block:: c | ||
|
|
||
| mlx_stream stream = mlx_gpu_stream(); |
There was a problem hiding this comment.
Does this need to be destroyed? Maybe not since it isn't new?
There was a problem hiding this comment.
No, I think it needs to be freed -- the implementation of this is:
extern "C" mlx_stream mlx_gpu_stream() {
try {
return mlx_stream_new_(
| /** | ||
| * Get stream description. | ||
| */ | ||
| mlx_string mlx_stream_tostring(mlx_device stream); |
There was a problem hiding this comment.
| mlx_string mlx_stream_tostring(mlx_device stream); | |
| mlx_string mlx_stream_tostring(mlx_stream stream); |
| int mlx_fast_metal_kernel_set_input_names( | ||
| mlx_fast_metal_kernel cls, | ||
| int num, | ||
| ...); |
There was a problem hiding this comment.
Per offline discussion swift can't call variadic C functions
| const mlx_array a, | ||
| const mlx_stream s) { | ||
| try { | ||
| std::tie(mlx_array_get_(*res_0), mlx_array_get_(*res_1)) = |
There was a problem hiding this comment.
I get:
MLX error: expected a non-empty mlx_array at mlx-swift2/Source/Cmlx/include/mlx/c/linalg.cpp:161
from calling like this:
public func qr(_ array: MLXArray, stream: StreamOrDevice = .default) -> (MLXArray, MLXArray) {
var r0 = mlx_array_new()
var r1 = mlx_array_new()
mlx_linalg_qr(&r0, &r1, array.ctx, stream.ctx)
return (MLXArray(r0), MLXArray(r1))
}The mlx_array_get() doesn't seem like it is meant to be used on out params.
| mlx_fast_metal_kernel cls, | ||
| const mlx_vector_array inputs, | ||
| const mlx_stream stream, | ||
| mlx_vector_array* outputs); |
There was a problem hiding this comment.
Per offline discussion this function doesn't match the pattern of other functions -- the out parameter is last instead of first.
| const mlx_array key, | ||
| const mlx_stream s) { | ||
| try { | ||
| std::tie(mlx_array_get_(*res_0), mlx_array_get_(*res_1)) = |
There was a problem hiding this comment.
Another case of:
MLX error: expected a non-empty mlx_array at mlx-swift2/Source/Cmlx/include/mlx/c/random.cpp:281
I think mlx_array_get() is not meant to be used on out parameters.
This introduces the new API of MLX C