Additional args to the chp-start command can now be passed via an env…

…ironment variable ADDITIONAL_ARGS instead of passing it as arguments to the container

README.md

@@ -98,7 +98,7 @@ Here are the additional environment variables for the hub:
     </tr>
     <tr>
         <td>START_CHP</td>
-        <td>Start the Jupyterhub proxy process separately (The hub should not start the proxy itself, which can be configured via the Jupyterhub config file. This option is built-in to work with <a href="https://github.com/ml-tooling/zero-to-mlhub-k8s"> zero-to-mlhub-k8s</a>, where the image is also used as the Configurable-Http-Proxy (CHP) image. Args passed to the container are passed to the chp-start command.</td>
+        <td>Start the Jupyterhub proxy process separately (The hub should not start the proxy itself, which can be configured via the Jupyterhub config file. This option is built-in to work with <a href="https://github.com/ml-tooling/zero-to-mlhub-k8s"> zero-to-mlhub-k8s</a>, where the image is also used as the Configurable-Http-Proxy (CHP) image. Additional arguments to the chp-start command can be passed to the container by passing an environment variable ADDITIONAL_ARGS, e.g. --env ADDITIONAL_ARGS="--ip=0.0.0.0 --api-ip=0.0.0.0".</td>
         <td>false</td>
     </tr>
 </table>

resources/docker-entrypoint.sh

@@ -2,9 +2,7 @@
 
 printf "Starting ML Hub\n"
 
-# $@ corresponds to the incoming script arguments
-incoming_args="$@"
-echo "$incoming_args"
+incoming_args="$ADDITIONAL_ARGS"
 execution_mode=${EXECUTION_MODE:-local}
 if [ "$execution_mode" == "k8s" ]; then
   # make changes to nginx so that it works in Kubernetes as well