Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Powered By" page for the MLflow website #22

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

daniellok-db
Copy link
Collaborator

@daniellok-db daniellok-db commented Feb 1, 2024

Add a page on the new website to put all the company logos:

Screen.Recording.2024-02-02.at.3.15.11.PM.mov

I'm not super sure what the content should be, let me know if anyone has any better suggestions! I tried to include all of the companies from the old website's logo section, but some of them are now defunct / got acquired / don't have SVG logos. My thought was that if any organization wants their logo on the new site, they can reach out to us and we can ask them to provide an SVG we can use.

The logos are also sorted alphabetically, but let me know if there's any specific order we want!

Signed-off-by: Daniel Lok <daniel.lok@databricks.com>
Signed-off-by: Daniel Lok <daniel.lok@databricks.com>
Signed-off-by: Daniel Lok <daniel.lok@databricks.com>
Copy link

github-actions bot commented Feb 1, 2024

Preview for 64ad852

  • For faster build, the doc pages are not included in the preview.
  • Redirects are disabled in the preview.
Open in StackBlitz

@@ -0,0 +1,64 @@
{
"ABN AMRO": "https://www.abnamro.com",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the structure of this file can be modified. for now i kept it simple with `{ <name>: <url> }, but we could also do something like:

{
  <name>: {
    url: <url>,
    src: <path/to/logo.svg>,
    // other fields?
  },
  ...
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer the name: {url, src} style.

Signed-off-by: Daniel Lok <daniel.lok@databricks.com>
Signed-off-by: Daniel Lok <daniel.lok@databricks.com>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we create a powered-by directory and changed this file to website/src/pages/powered-by/index.tsx?

@BenWilson2
Copy link
Member

cc @mahesh-venkatachalam What do you think of the layout and feel of the added page?

Comment on lines 51 to 56
and contributing to MLflow. To add your organization here, email our
user list at{" "}
<a href="https://groups.google.com/g/mlflow-users">
mlflow-users@googlegroups.com
</a>
!
Copy link
Member

@harupy harupy Feb 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we replace "email our user list at ..." with "open a PR at https://github.com/mlflow/mlflow-website"?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can file another PR to add a new logo once this PR is merged, and put that PR as an example like below:

open a PR at https://github.com/mlflow/mlflow-website (example)
                                                      ^^^^^^^^^

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh yeah that would be much better haha

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed MosaicML from this list, and will add it back in a PR later after this lands so we can provide an example

Signed-off-by: Daniel Lok <daniel.lok@databricks.com>
Signed-off-by: Daniel Lok <daniel.lok@databricks.com>
Signed-off-by: Daniel Lok <daniel.lok@databricks.com>
@harupy
Copy link
Member

harupy commented Feb 2, 2024

The logo are colored when the screen is narrow. Is this intended?

image

@daniellok-db
Copy link
Collaborator Author

daniellok-db commented Feb 2, 2024

The logo are colored when the screen is narrow. Is this intended?

Yup, I did some testing and realized that the hover action doesn't work on mobile, so I just decided to make them colored

Copy link
Member

@harupy harupy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants