make immutable=1 imply SQLITE_OPEN_READONLY

mlin · Jan 13, 2024 · e3275cf · e3275cf
1 parent 2e9c7db
commit e3275cf
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/src/SQLiteNestedVFS.h b/src/SQLiteNestedVFS.h
@@ -1005,6 +1005,7 @@ class InnerDatabaseFile : public SQLiteVFS::File {
             }
         } catch (SQLite::Exception &exn) {
             SQLITE_NVFS_LOG(1, exn.what())
+            SQLiteVFS::File::Close(); // deletes this
             return exn.getErrorCode();
         }
         unsigned long long sequential = 0, non_sequential = 0, interior_hits = 0;
@@ -1027,7 +1028,7 @@ class InnerDatabaseFile : public SQLiteVFS::File {
                                    << "ms decode: " << t_decode.count() / 1000000 << "ms")
         }
         SQLITE_NVFS_LOG(3, "xClose")
-        return SQLiteVFS::File::Close();
+        return SQLiteVFS::File::Close(); // deletes this
     }
 
     int ShmMap(int iPg, int pgsz, int isWrite, void volatile **pp) override {
@@ -1222,6 +1223,7 @@ class VFS : public SQLiteVFS::Wrapper {
                     outer_db_uri += "?nolock=1&psow=1";
                 } else if (sqlite3_uri_boolean(zName, "immutable", 0)) {
                     outer_db_uri += "?immutable=1";
+                    flags |= SQLITE_OPEN_READONLY;
                 }
                 if (log_filename_.rfind('/') != std::string::npos) {
                     log_filename_ = log_filename_.substr(log_filename_.rfind('/') + 1);