Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre commit #167

Merged
merged 10 commits into from
Oct 13, 2023
Merged

Pre commit #167

merged 10 commits into from
Oct 13, 2023

Conversation

mmaelicke
Copy link
Owner

Continuation of #163

I merged into a non-main branch to push some stuff before merging into main

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (01e13fe) 90.34% compared to head (96b671c) 90.34%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #167   +/-   ##
=======================================
  Coverage   90.34%   90.34%           
=======================================
  Files          23       23           
  Lines        2393     2393           
=======================================
  Hits         2162     2162           
  Misses        231      231           
Files Coverage Δ
skgstat/DirectionalVariogram.py 90.25% <ø> (ø)
skgstat/Kriging.py 85.83% <ø> (ø)
skgstat/MetricSpace.py 85.61% <ø> (ø)
skgstat/SpaceTimeVariogram.py 83.03% <ø> (ø)
skgstat/Variogram.py 95.93% <ø> (ø)
skgstat/__version__.py 100.00% <100.00%> (ø)
skgstat/binning.py 100.00% <100.00%> (ø)
skgstat/data/__init__.py 94.54% <ø> (ø)
skgstat/data/_loader.py 78.00% <ø> (ø)
skgstat/interfaces/gstools.py 97.22% <100.00%> (ø)
... and 9 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmaelicke
Copy link
Owner Author

@rhugonnet I finally found the time to do the codespell pre-commit.

The check is now passing, so we can continue from here. Do you want to add more checks on this branch, before merging?
We discussed trailing whitespace, check-yaml, end-of-file fixer

@mmaelicke mmaelicke merged commit c2d63d1 into main Oct 13, 2023
17 of 21 checks passed
@mmaelicke mmaelicke deleted the pre-commit branch October 13, 2023 05:14
@rhugonnet
Copy link
Contributor

Amazing, great additions :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants