Fix issue where Retcon could return unparsed reference tags. Bump to …

…2.7.3. Fixes #63
mmikkel · Aug 1, 2023 · 81fe0d5 · 81fe0d5
1 parent 852289d
commit 81fe0d5
Show file tree

Hide file tree

Showing 4 changed files with 93 additions and 88 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,11 @@
 # Retcon Changelog
 
+## 2.7.3 - 2023-08-01
+
+### Fixed  
+
+- Fixed a regression introduced in Retcon 2.7.0, where Retcon would return unparsed reference tags from Redactor/CKEditor output, in cases where there were no nodes matching the given selector.   
+
 ## 2.7.2 - 2023-07-30
 
 ### Fixed

diff --git a/composer.json b/composer.json
@@ -2,7 +2,7 @@
     "name": "mmikkel/retcon",
     "description": "Powerful Twig filters for mutating and querying HTML",
     "type": "craft-plugin",
-    "version": "2.7.2",
+    "version": "2.7.3",
     "keywords": [
         "craft",
         "cms",

diff --git a/src/helpers/RetconHelper.php b/src/helpers/RetconHelper.php
@@ -51,6 +51,9 @@ class RetconHelper
      */
     public static function getHtmlFromParam($value): ?string
     {
+        if (empty($value)) {
+            return null;
+        }
         if ($value instanceof RedactorFieldData || $value instanceof HtmlFieldData) {
             $html = $value->getRawContent();
         } else {