Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port to master: Fix build with stock GC: mmtk_pin_object is conditionaly compiled (#42) #45

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Port to master: Fix build with stock GC: mmtk_pin_object is conditionaly compiled (#42) #45

wants to merge 1 commit into from

Conversation

qinsoon
Copy link
Member

@qinsoon qinsoon commented Mar 27, 2024

No description provided.

@qinsoon qinsoon requested a review from udesou March 27, 2024 00:34
udesou pushed a commit to udesou/julia that referenced this pull request Aug 19, 2024
@topolarity @JeffBezanson
improve inference of CPU_THREADS in Sys.__init__ (JuliaLang#54384)
99bda02 
Without this change, the compiler fails to notice that `env_threads isa
Int` in the fall-through case, leading to a union-split with a branch
that is in fact unreachable:

```
43 ┄ %109 = φ (mmtk#41 => %105, mmtk#42 => %108)::Union{Nothing, Int64}
│    %110 = (%109 isa Int64)::Bool
└───        goto mmtk#45 if not %110
...
45 ─ %126 = π (%109, Nothing)
│           Base.convert(Int64, %126)::Union{}
└───        unreachable
```

After this change, the union-split is eliminated.

Co-authored-by: Jeff Bezanson <jeff.bezanson@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@udesou udesou Awaiting requested review from udesou

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@qinsoon