-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump to 2.0.0 #692
base: master
Are you sure you want to change the base?
chore: bump to 2.0.0 #692
Conversation
It's way too early to release 2.0.0 given the PRs backlog:
|
Happy to make another release this week with those changes once merged. The aim of 2.0.0 is to officially release all changes since the last official release 0.26 which was 11 months ago |
The last official release is 1.0.0 and was not synced with GitHub release. A major release is expected to include every single deprecation change BEFORE, not after. Doing the opposite is a very bad releasing practice. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please include pending PRs before releasing new library.
And I agree with @jerome-benoit , since most people install via pypi, the last official release is 1.0.0, even if it wasn't marked in github as a release.
if anything, this chore should be to create a github release to match what was released to pypi as 1.0.0
@@ -1,6 +1,6 @@ | |||
[tool.poetry] | |||
name = "ocpp" | |||
version = "2.0.0-rc.3" | |||
version = "2.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please include pending PRs before releasing a new version.
Will merge the pending PR's before releasing 2.0.0 |
thanks! greatly appreciated! |
No description provided.