Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump to 2.0.0 #692

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore: bump to 2.0.0 #692

wants to merge 1 commit into from

Conversation

mdwcrft
Copy link
Collaborator

@mdwcrft mdwcrft commented Dec 9, 2024

No description provided.

@mdwcrft mdwcrft requested a review from proelke as a code owner December 9, 2024 09:35
@mdwcrft mdwcrft requested a review from jainmohit2001 December 9, 2024 09:40
@jerome-benoit
Copy link
Contributor

jerome-benoit commented Dec 9, 2024

It's way too early to release 2.0.0 given the PRs backlog:

  • OCPP 2 enums namespace fix
  • OCPP 2 type definitions
  • Version support documentation
  • ...

@mdwcrft
Copy link
Collaborator Author

mdwcrft commented Dec 9, 2024

It's way too early to release 2.0.0 given the PRs backlog:

  • OCPP 2 enums namespace fix

  • OCPP 2 type definitions

  • Version support documentation

  • ...

Happy to make another release this week with those changes once merged. The aim of 2.0.0 is to officially release all changes since the last official release 0.26 which was 11 months ago

@jerome-benoit
Copy link
Contributor

jerome-benoit commented Dec 9, 2024

It's way too early to release 2.0.0 given the PRs backlog:

  • OCPP 2 enums namespace fix
  • OCPP 2 type definitions
  • Version support documentation
  • ...

Happy to make another release this week with those changes once merged. The aim of 2.0.0 is to officially release all changes since the last official release 0.26 which was 11 months ago

The last official release is 1.0.0 and was not synced with GitHub release.

A major release is expected to include every single deprecation change BEFORE, not after. Doing the opposite is a very bad releasing practice.

@jainmohit2001 jainmohit2001 changed the title bump to 2.0.0 chore: bump to 2.0.0 Dec 9, 2024
Copy link
Contributor

@ajmirsky ajmirsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please include pending PRs before releasing new library.

And I agree with @jerome-benoit , since most people install via pypi, the last official release is 1.0.0, even if it wasn't marked in github as a release.

if anything, this chore should be to create a github release to match what was released to pypi as 1.0.0

@@ -1,6 +1,6 @@
[tool.poetry]
name = "ocpp"
version = "2.0.0-rc.3"
version = "2.0.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please include pending PRs before releasing a new version.

@jainmohit2001
Copy link
Collaborator

Will merge the pending PR's before releasing 2.0.0

@ajmirsky
Copy link
Contributor

ajmirsky commented Dec 9, 2024

Will merge the pending PR's before releasing 2.0.0

thanks! greatly appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants