Add forwardWithCallback #169
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
missing implementation in |
|
@jamesdbloom is it possible to merge and release this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've created
forwardWithCallback()in the style ofmockWithCallback(), tried to make as minimal change as possible, could reuse some of the code increateExpectationWithCallbackbut opted to keep it all separateThe only difference in contract with
mockWithCallback()is therequestAndResponseHandler, which if present triggersresponseCallback: true. Don't know if there are other scenarios other than replying an HttpRequest and then a HttpResponse to the websocket but I can implement them if neededIf approach is approved I can look into testing and later updating the docs for the javascript example