Adds memory snapshot examples #609
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luiscape
changed the title
08_advanced/memory_snapshots/sdxl.py
Outdated
|
|
||
| ## Create a modal class with memory snapshots enabled | ||
| # | ||
| # `checkpointing_enabled=True` creates a Modal class with memory snapshots enabled. |
There was a problem hiding this comment.
(Think you know already that these are stale)
08_advanced/memory_snapshots/sdxl.py
Outdated
| self.pipe.to("cpu") | ||
|
|
||
| @modal.enter(checkpoint=False) | ||
| def setup(self): |
There was a problem hiding this comment.
Suggested change
| def setup(self): | |
| def load_to_gpu(self): |
08_advanced/memory_snapshots/sdxl.py
Outdated
| image = ( | ||
| modal.Image.debian_slim() | ||
| .pip_install( | ||
| "torch", |
There was a problem hiding this comment.
Also these deps should be == pinned. Ref Review of synmon on Examples in our Notion.
|
|
||
| image = ( | ||
| modal.Image.debian_slim() | ||
| .pip_install("transformers", "datasets", "hf_transfer", "torch", "librosa", "soundfile") |
There was a problem hiding this comment.
Also these deps should be == pinned. Ref Review of synmon on Examples in our Notion.
| .apt_install("ffmpeg", "libsm6", "libxext6") | ||
| .env({"HF_HUB_ENABLE_HF_TRANSFER": "1"}) | ||
| ) | ||
| stub = modal.Stub("sdxl", image=image) |
There was a problem hiding this comment.
These examples should be prefixed with example-
|
|
||
|
|
||
|
|
||
| if __name__ == "__main__": |
There was a problem hiding this comment.
Think there should be some docs here explaining that you first need to deploy this app and then run it. Would also be good to catch 'not found' on lookup and print a helpful error about the user likely not deploying
luiscape
changed the title
CloudBucketMount examples
luiscape
changed the title
CloudBucketMount examples…/memory_snapshot_examples
…/memory_snapshot_examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds memory snapshotting examples for:
I'll update the memory snapshotting interface before merging these.
Also adds example for our
CloudBucketMountwhere we mount an S3 bucket.