Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Jupyter example #667

Merged
merged 2 commits into from
Mar 26, 2024
Merged

Fix Jupyter example #667

merged 2 commits into from
Mar 26, 2024

Conversation

mwaskom
Copy link
Contributor

@mwaskom mwaskom commented Mar 26, 2024

Noticed that this was red in the example synmon — it was a casualty of the .new() deprecation.

I also updated it to demonstrate Volume which we're trying to encourage everyone to adopt.

Funny enough we rolled out the new Volume viewer in the dashboard — which kind of obviates this example. We should think of a better hook for demonstrating the features here.


Additionally, there are a few bonus fixes for the stub.<object> deprecation that landed recently.

Copy link

@modal-pr-review-automation modal-pr-review-automation bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approved 👍. This diff qualified for automatic approval and doesn't need follow up review.

@mwaskom mwaskom merged commit 1242bd2 into main Mar 26, 2024
4 checks passed
@mwaskom mwaskom deleted the michael/fix-jupyter-example branch March 26, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant