Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for MODCLUSTER-841, use updated to propagate the status and error_time. #849

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

jfclere
Copy link
Member

@jfclere jfclere commented Nov 19, 2024

Fix: https://issues.redhat.com/browse/MODCLUSTER-841

This change is NOT relevant in upstream, the http/ws logic is different.

@jfclere jfclere requested review from aogburn and jajik November 19, 2024 08:43
Copy link
Collaborator

@jajik jajik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me

http_worker = get_http_worker(s, worker);
if (http_worker != NULL) {
if (http_worker->s->status != worker->s->status ||
http_worker->s->error_time !=worker->s->error_time) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing space after !=, but that's not a big deal

@jfclere
Copy link
Member Author

jfclere commented Nov 19, 2024

@jajik I have fixed the style coding missing space.

@jajik
Copy link
Collaborator

jajik commented Nov 19, 2024

Thanks! Feel free to squash it into one commit.

@jfclere
Copy link
Member Author

jfclere commented Nov 19, 2024

@jajik Done

@jajik jajik added 1.3.x Issues and PRs for the 1.3.x branch bug labels Nov 20, 2024
@jajik jajik merged commit 937ceb4 into modcluster:1.3.x Nov 20, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.3.x Issues and PRs for the 1.3.x branch bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants