Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MODCLUSTER-848 Move to Java SE 17 as the minimum SE version #858

Merged
merged 2 commits into from
Dec 17, 2024
Merged

MODCLUSTER-848 Move to Java SE 17 as the minimum SE version #858

merged 2 commits into from
Dec 17, 2024

Conversation

rhusar
Copy link
Member

@rhusar rhusar commented Dec 17, 2024 •
edited
Loading

  • Cleans up a lot of build cruft needed to support both 11/17
  • and significantly reduces required CI.
  • Uses maven-wrapper for deterministic builds.

Resolves
https://issues.redhat.com/browse/MODCLUSTER-848

jajik
jajik reviewed Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@jajik jajik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's nice. But I would consider separating CI changes into another commit.

@rhusar
Copy link
Member Author

rhusar commented Dec 17, 2024

That's nice. But I would consider separating CI changes into another commit.

OK, done, even though one cannot exist without the other, but neither I like mixing this infra with actual project code.

jajik
jajik approved these changes Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@jajik jajik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rhusar rhusar merged commit df84146 into modcluster:main Dec 17, 2024
9 checks passed
@rhusar rhusar deleted the MODCLUSTER-848 branch December 17, 2024 10:41
@rhusar
Copy link
Member Author

rhusar commented Dec 17, 2024

Thanks @jajik and @pferraro

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jajik jajik jajik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rhusar @jajik