Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

js-tests.md: Refer to chai as an ES module #2716

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

olleolleolle
Copy link
Contributor

Since 5.0, chai is distributed as an ES module, no need for the wrapper.

What I did

  1. I modernized the reference to chai in the example.

Since 5.0, chai is distributed as an ES module, no need for the wrapper.
Copy link

changeset-bot bot commented Apr 24, 2024

⚠️ No Changeset found

Latest commit: 254148a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@bashmish
Copy link
Member

bashmish commented Apr 24, 2024

There are many more mentions of @esm-bundle/chai in the code.
In the documentation should be easy to do that.
In the code and tests I think this is a required change too then, also to verify all works with chai 5.x.
I think these changes should go as a whole.

@olleolleolle
Copy link
Contributor Author

@bashmish Thanks! I took a look, learned a little about the structure, and then saw this was too big of a change for me to do without knowing more about the project.

If someone wants to carry this change, be welcome to it!

@bashmish
Copy link
Member

I think this is a good first issue. It's impactful, but if chai 5 is compatible, it should be relatively easy to do.
This can help to start changing and prepare a PR https://github.com/modernweb-dev/web/blob/master/CONTRIBUTING.md

Copy link
Member

@bashmish bashmish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@esm-bundle/chai needs to be replaced with chai native ESM everywhere in the docs, code and tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants