fix(remove_model): remove_model method fix and tests (#1916) #1945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1945 +/- ##
=======================================
Coverage 72.6% 72.6%
=======================================
Files 257 257
Lines 57689 57711 +22
=======================================
+ Hits 41911 41927 +16
- Misses 15778 15784 +6
|
Method remove_model removes all references to the model from the simulation namefile. Tests added to autotest.
|
Rebased to remove older/unrelated changes and added a non-regression test case |
This was referenced Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Method remove_model removes all references to the model from the simulation namefile. Tests added to autotest.