Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(datafile): ignore lint rule for codacy, pending refactor #2363

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

wpbonelli
Copy link
Member

@wpbonelli wpbonelli commented Nov 12, 2024

Codacy began detecting a "severe" pylint E1126 invalid sequence index violation in #2362.

Sequence index is not an int, slice, or instance with index

The issue pre-existed that PR, I think the format changes just revealed it. We could just ignore it in the web UI but this is probably worth coming back to, to appease linters and type checkers and to make the code easier to reason about.

Relatedly, there is work ongoing to make ruff work with codacy, so hopefully in future we can use ruff ignore syntax for things like this if/when needed

@wpbonelli wpbonelli marked this pull request as ready for review November 12, 2024 21:37
@wpbonelli wpbonelli merged commit dc394cd into modflowpy:develop Nov 12, 2024
23 checks passed
@wpbonelli wpbonelli deleted the codacy-fix branch November 12, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant