Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: fix long lines to resolve check E501 #2368

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

mwtoews
Copy link
Contributor

@mwtoews mwtoews commented Nov 14, 2024

This refactor resolves long line checks. See ruff check code E501 for more.

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 2 lines in your changes missing coverage. Please review.

Project coverage is 76.2%. Comparing base (dc394cd) to head (0e3add9).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
flopy/export/metadata.py 0.0% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           develop   #2368     +/-   ##
=========================================
+ Coverage     74.5%   76.2%   +1.6%     
=========================================
  Files          292     292             
  Lines        59624   59625      +1     
=========================================
+ Hits         44463   45461    +998     
+ Misses       15161   14164    -997     
Files with missing lines Coverage Δ
flopy/discretization/grid.py 75.7% <ø> (+0.6%) ⬆️
flopy/discretization/unstructuredgrid.py 81.0% <ø> (+0.1%) ⬆️
flopy/export/netcdf.py 49.2% <ø> (ø)
flopy/export/shapefile_utils.py 84.0% <ø> (ø)
flopy/export/utils.py 64.6% <ø> (ø)
flopy/export/vtk.py 78.0% <ø> (ø)
flopy/mbase.py 72.1% <ø> (ø)
flopy/mfusg/mfusgbcf.py 80.4% <ø> (ø)
flopy/mfusg/mfusglpf.py 80.4% <ø> (ø)
flopy/modflow/mf.py 69.2% <ø> (ø)
... and 31 more

... and 75 files with indirect coverage changes

@wpbonelli wpbonelli merged commit bb9824e into modflowpy:develop Nov 14, 2024
23 checks passed
@mwtoews mwtoews deleted the fix-E501 branch November 14, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants