Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tach package to dev for dependency analysis #2373

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

deltamarnix
Copy link
Contributor

Creates visualizations of the import statements in the code. See DEVELOPER.md on how to use it.

Creates visualizations of the import statements in the code.
See DEVELOPER.md on how to use it
@deltamarnix
Copy link
Contributor Author

I think this is a very handy tool to generate mermaid files with information on the dependencies between modules internal to flopy. I have committed the tach.toml as a starting point with settings that help to analyze the mf6 module and the utility packages surrounding it.

If you think this has value, merge it. If this is too auxiliary for what flopy stands for, I understand.

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.5%. Comparing base (bb9824e) to head (548f479).
Report is 7 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff            @@
##           develop   #2373     +/-   ##
=========================================
+ Coverage     68.4%   74.5%   +6.1%     
=========================================
  Files          294     292      -2     
  Lines        59390   59623    +233     
=========================================
+ Hits         40652   44468   +3816     
+ Misses       18738   15155   -3583     

see 227 files with indirect coverage changes

---- 🚨 Try these New Features:

Copy link
Member

@wpbonelli wpbonelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems useful and maybe encourages explicit decisions about visibility?

@wpbonelli wpbonelli merged commit b8d3707 into modflowpy:develop Nov 18, 2024
23 checks passed
@deltamarnix deltamarnix deleted the tach-dep-analysis branch November 19, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants