Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS-#6416: fix import path for spreadsheet feature #6581

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

anmyachev
Copy link
Collaborator

@anmyachev anmyachev commented Sep 18, 2023

What do these changes do?

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves BUG: No module named 'modin.spreadsheet' #6416
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
@anmyachev
Copy link
Collaborator Author

@mvashishtha could you make new release of modin[spreadsheet]? Then we can upgrade the pin in Modin to a working version.

@anmyachev anmyachev marked this pull request as ready for review September 18, 2023 17:58
@anmyachev anmyachev requested a review from a team as a code owner September 18, 2023 17:58
@mvashishtha
Copy link
Collaborator

@anmyachev I can make a release, but do we need a release before merging this PR?

@anmyachev
Copy link
Collaborator Author

@anmyachev I can make a release, but do we need a release before merging this PR?

no, firstly - new release of https://github.com/modin-project/modin-spreadsheet. Then we will update pin in modin something like:

spreadsheet_deps = ["modin-spreadsheet>=0.1.3"] (instead of >=0.1.0)

At the end we will release Modin itself (with updated pin).

@anmyachev anmyachev merged commit 23ebe6b into modin-project:master Sep 20, 2023
5 checks passed
@anmyachev anmyachev deleted the issue6416 branch September 20, 2023 11:26
@anmyachev
Copy link
Collaborator Author

@anmyachev I can make a release, but do we need a release before merging this PR?

@mvashishtha what about making a release of modin-spreadsheet? Do you have time for that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: No module named 'modin.spreadsheet'
3 participants