Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map Tags #1086

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

Map Tags #1086

wants to merge 11 commits into from

Conversation

tsa96
Copy link
Member

@tsa96 tsa96 commented Dec 20, 2024

Draft for now, frontend needs a little more work, just want to check CI

Closes #503

Adds a tags field to leaderboards/leaderboard suggestions, an array of gamemode-dependent strings.

Deliberately extremely simple, just plain JS strings stored in Postgres as a text array. Tags are stored in TypeScript source. Game C++ will never need to store individual tags, we'll just pass strings in from Panorama Typescript, which has a copy of that TS file via the fetch script that pulls everything from libs/constants.

I'm adding stuff according to this google sheet, can continue adding new tags as people request stuff.

Screenshots

image

Checks

  • !! DONT IGNORE ME !! I have ran nx run db:create-migration <name> and committed the migration if I've made DB schema changes
  • I have included/updated tests where applicable (see Testing)
  • I have followed semantic commit messages e.g. feat: Add foo, chore: Update bar, etc...
  • My branch has a clear history of changes that can be easy to follow when being reviewed commit-by-commit
  • My branch is functionally complete; the only changes to be done will be those potentially requested in code review
  • All changes requested in review have been fixuped into my original commits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tags to maps
1 participant